Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Network Disconnects #970

Open
MaxCWhitehead opened this issue Apr 14, 2024 · 2 comments
Open

Handle Network Disconnects #970

MaxCWhitehead opened this issue Apr 14, 2024 · 2 comments

Comments

@MaxCWhitehead
Copy link
Collaborator

MaxCWhitehead commented Apr 14, 2024

Description

Right now when a player disconnects, there isn't really any indication other than them stopping moving.

We should notify the player of this, and consider switching the remote player to an AI or something. That might be a bit more work - but some sort of toast message / discrete UI making known would be good.

@erlend-sh
Copy link
Member

Ideally we would at the very least:

  • pause game
  • include a little notice that player dropped out.

@MaxCWhitehead
Copy link
Collaborator Author

MaxCWhitehead commented Jun 9, 2024

This is partially handled - when all players DC, player is notified with option to leave game.

When only a subset of players DC'd, should continue game but add UI to indicate this.

This issue is relevant for disconnects outside of game / while still setting it up: #1004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants