Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Next.js #307

Open
AugustinMauroy opened this issue Feb 26, 2023 · 12 comments
Open

Migration to Next.js #307

AugustinMauroy opened this issue Feb 26, 2023 · 12 comments

Comments

@AugustinMauroy
Copy link

馃悶 Problem

Simple CRA it's difficult to maintain.

馃幆 Goal

Add this feat:

  • next.js meta framwork
  • typescript support
  • sass support
  • unit test for components

馃搵 Steps to solve the problem

  • First pr to migrate
  • Seconde to add Linter like ES-lint
  • Third pr for sass
  • add unit test
@izkizk8
Copy link

izkizk8 commented Mar 3, 2023

Hey bro, it's sounds pretty good~馃槉
But this repository seems no one maintain any more I think
Maybe you're doing this now...鉂わ笍

@AugustinMauroy
Copy link
Author

CC @Roshanjossey

@mirsahib
Copy link

mirsahib commented Jul 4, 2023

Is this project still alive I can help you guys on migrating to nextjs

@Esh07
Copy link

Esh07 commented Jul 18, 2023

Hey @AugustinMauroy ,

I'm a little curious about this issue and wanted to check if there has been any progress or if any initial steps have been taken to address it.

I have a suggestion that could take the project to the next level. Have you considered using a framework like Next.js, similar to Docasaurus? It's incredibly user-friendly, and practical, and can provide a lot of helpful features.

I'd love to hear your thoughts on this idea. Let me know what you think!

@AugustinMauroy
Copy link
Author

@Esh07

  1. We wait maintainer validation (And I鈥檓 waiting for write acces)
  2. For using daucosorus, I鈥檓 not fan because it鈥檚 less flexible. And for i18n it鈥檚 become complicated on infrastructure pov
    Thanks for your interest
    sorry for the strange message I鈥檓 on phone because I鈥檓 not at home

@Esh07
Copy link

Esh07 commented Jul 19, 2023

For using daucosorus, I鈥檓 not fan because it鈥檚 less flexible. And for i18n it鈥檚 become complicated on infrastructure pov
Thanks for your interest.

Oh, okay. I believe it鈥檚 quite simple. Docusaurus is flexible in terms of implementing small documentation like we have on the first-contribution repository. It also has features for implementing blogs and we can make a separate page for listing projects. On top of that, it makes things even easier with GitHub integration for CI/CD, unit testing, and more.

From my experience, I find it easy to use because you don鈥檛 have to worry about handling routing. They鈥檝e made it simple to manage. And I think for this repository, it鈥檚 enough.

In terms of infrastructure, we can even make smaller fragments of docs to manage each file, which makes life easier for maintainers and reviewers.

And even Docusaursdoes does provide a solution for i18n.

This is my thought and suggestion.

However, 馃槉 I am open to further discussion and welcome any ideas.

@Roshanjossey
Copy link
Member

Roshanjossey commented Jul 21, 2023

This app loads data about projects from a json file and renders it.

What does it need Typescript and SASS support for? What architectural problem is fixed by using Nextjs?

Simple CRA it's difficult to maintain.

How does this statement apply to this app?

@AugustinMauroy
Copy link
Author

AugustinMauroy commented Jul 30, 2023

hey !

How does this statement apply to this app?

In general Nextjs app is more easy to maintain than CRA.

Also use nextjs increase DX. And simplify coding. So it's allow more poeple to contribue.

Other point, we can i18n website esalier.

to continue we will have an better SEO

@Roshanjossey
Copy link
Member

Not in general, specific to this project.

When you have a hammer, everything might look like a nail. We should be wise to use right tools for respective scenarios.

I like Nextjs a lot. For the last 3 years, I have preferred it over CRA.
Think about it this way. What features of Next does this app need that CRA is not doing now?
Does it need routing? api functions? ISR?

increase DX. And simplify coding. So it's allow more poeple to contribue.

This is a generic statement that can be said about a lot of things. Like for Docker or Kubernetes
But does this project need any of that?

Do the benefits of such a refactor justify the effort of people doing it? Maintainers reviewing the changes?

@AugustinMauroy
Copy link
Author

you should take a look to this draft to have an better understanding

@Roshanjossey
Copy link
Member

Doesn't answer any of the questions @AugustinMauroy. Question is not if we can do it. It's if we should do it

@AugustinMauroy
Copy link
Author

Do the benefits of such a refactor justify the effort of people doing it? Maintainers reviewing the changes?

Yeah I'm 100% sure.

But does this project need any of that?

As I said above, I think so. Thanks to nextjs lots of possibilities are opening up. Like i18n, several pages that give advice (which would be written in markdown/mdx)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants