Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrepancy in flag dimensions provided in README.md #84022

Open
kenshanta opened this issue May 4, 2024 · 3 comments
Open

Discrepancy in flag dimensions provided in README.md #84022

kenshanta opened this issue May 4, 2024 · 3 comments
Assignees
@Roshanjossey
Labels
discussion question

Comments

@kenshanta
Copy link

kenshanta commented May 4, 2024 •
edited

馃悶 Problem

  • Flags not respecting a single dimension
    i.e (first 2) Albania & Armenia
Screenshot 2024-05-04 at 8 12 51鈥疨M

馃挕 Possible solutions

  • hardcoding dimensions
  • different svg source

Pull Request #84052
@kenshanta kenshanta mentioned this issue May 6, 2024
Closed
@Seba-Aguero
Copy link

Hello! I would like to work on this issue.

@kenshanta
Copy link
Author

Hello! I would like to work on this issue.

Pull request already created, please check the first comment.

Feel free to provide any feedback on the changes.

Also im curious to know which approach you would take to solve this problem.

@kenshanta
Copy link
Author

@Roshanjossey can i get the lead on this? Also i would like to maintain the issues and review PRs as i am available of the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Roshanjossey Roshanjossey

Labels
discussion question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Roshanjossey @Seba-Aguero @kenshanta