Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSGenericException in InstrumentUploadTaskWithStreamedRequest #12983

Closed
KarimEbrahemMansour opened this issue May 17, 2024 · 3 comments · Fixed by #12991
Closed

NSGenericException in InstrumentUploadTaskWithStreamedRequest #12983

KarimEbrahemMansour opened this issue May 17, 2024 · 3 comments · Fixed by #12991
Assignees
@paulb777 @visumickey
Labels
api: performance
Milestone
10.28.0 - M149

Comments

@KarimEbrahemMansour
Copy link

Description

Description

Similar to #11821, our crash rate started to increase and the crash stack trace is pointing to this function InstrumentUploadTaskWithStreamedRequest.

Sample of our Crash Stacktrace

Fatal Exception: NSGenericException
0  CoreFoundation                 0xecb28 __exceptionPreprocess
1  libobjc.A.dylib                0x2af78 objc_exception_throw
2  CFNetwork                      0xdce4 _CFNetworkSetHSTSStoragePath
3  FirebasePerformance            0x18870 __InstrumentUploadTaskWithStreamedRequest_block_invoke + 486 (FPRNSURLSessionInstrument.m:486)
4  FirebasePerformance            0x18870 __InstrumentUploadTaskWithStreamedRequest_block_invoke + 486 (FPRNSURLSessionInstrument.m:486)
5  NewRelic                       0x38348 NRMAOverride__uploadTaskWithStreamedRequest + 355 (NRMAURLSessionOverride.m:355)
6  NewRelic                       0x530fc -[NRMAHexUploader handledErroredRequest:] + 141 (NRMAHexUploader.m:141)
7  NewRelic                       0x52cfc -[NRMAHexUploader URLSession:task:didCompleteWithError:] + 107 (NRMAHexUploader.m:107)
8  NewRelic                       0x353e8 -[NRURLSessionTaskDelegateBase URLSession:task:didCompleteWithError:] + 74 (NRMAURLSessionTaskDelegateBase.m:74)
9  FirebasePerformance            0x15eb4 __InstrumentURLSessionTaskDidCompleteWithError_block_invoke + 61 (FPRNSURLSessionDelegateInstrument.m:61)
10 CFNetwork                      0x1598c _CFNetworkSetHSTSStoragePath
11 libdispatch.dylib              0x213c _dispatch_call_block_and_release
12 libdispatch.dylib              0x3dd4 _dispatch_client_callout
13 libdispatch.dylib              0xb400 _dispatch_lane_serial_drain
14 libdispatch.dylib              0xbf64 _dispatch_lane_invoke
15 libdispatch.dylib              0x16cb4 _dispatch_root_queue_drain_deferred_wlh
16 libdispatch.dylib              0x16528 _dispatch_workloop_worker_thread
17 libsystem_pthread.dylib        0x1f20 _pthread_wqthread
18 libsystem_pthread.dylib        0x1fc0 start_wqthread

Reproducing the issue

No response

Firebase SDK Version

10.24.0

Xcode Version

15.3

Installation Method

CocoaPods

Firebase Product(s)

App Distribution, Crashlytics, Performance, Remote Config

Targeted Platforms

iOS

Relevant Log Output

No response

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet 
Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet 
Replace this line with the contents of your Podfile.lock!
@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@KarimEbrahemMansour
Copy link
Author

Hello @paulb777 ,

You provided a fix for other functions and mentioned in this issue that the issue could still exist in this scope.
The fix got deployed in the InstrumentUploadTaskWithRequestFromData function, but it looks like the same issue is still in InstrumentUploadTaskWithStreamedRequest.

Can you please take a look here?

Thank you.

@paulb777 paulb777 mentioned this issue May 17, 2024
Merged
@paulb777 paulb777 self-assigned this May 17, 2024
@paulb777 paulb777 added this to the 10.27.0 - M148 milestone May 17, 2024
@paulb777
Copy link
Member

Removing from 10.27.0 milestone.

@paulb777 paulb777 removed their assignment May 28, 2024
@paulb777 paulb777 removed this from the 10.27.0 - M148 milestone May 28, 2024
@paulb777 paulb777 added this to the 10.28.0 - M149 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulb777 paulb777

@visumickey visumickey

Labels
api: performance
Projects
None yet
Milestone
10.28.0 - M149
Development

Successfully merging a pull request may close this issue.

Fix fireperf exception firebase/firebase-ios-sdk
5 participants
@paulb777 @visumickey @google-oss-bot @argzdev @KarimEbrahemMansour