Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup]: Migrate away from GULSecureCoding in Firebase 11 #12922

Closed
ncooke3 opened this issue May 8, 2024 · 0 comments
Closed

[Cleanup]: Migrate away from GULSecureCoding in Firebase 11 #12922

ncooke3 opened this issue May 8, 2024 · 0 comments
Assignees
Milestone

Comments

@ncooke3
Copy link
Member

ncooke3 commented May 8, 2024

Description

FirebaseMessaging uses GULSecureCoding which provides a compat API (https://github.com/google/GoogleUtilities/blob/main/GoogleUtilities/Environment/Public/GoogleUtilities/GULSecureCoding.h) that will no longer be needed when the minimum version is raised in Firebase 11.

FirebaseMessaging/Sources/FIRMessagingPubSub.m:#import <GoogleUtilities/GULSecureCoding.h>
FirebaseMessaging/Sources/FIRMessagingPubSub.m-#import <GoogleUtilities/GULUserDefaults.h>
FirebaseMessaging/Sources/FIRMessagingPubSub.m-#import "FirebaseMessaging/Sources/FIRMessagingDefines.h"
FirebaseMessaging/Sources/FIRMessagingPubSub.m-#import "FirebaseMessaging/Sources/FIRMessagingLogger.h"
FirebaseMessaging/Sources/FIRMessagingPubSub.m-#import "FirebaseMessaging/Sources/FIRMessagingPendingTopicsList.h"
FirebaseMessaging/Sources/FIRMessagingPubSub.m-#import "FirebaseMessaging/Sources/FIRMessagingTopicOperation.h"
--
FirebaseMessaging/Sources/FIRMessagingPubSub.m:  NSData *pendingData = [GULSecureCoding archivedDataWithRootObject:topicsList error:&error];
FirebaseMessaging/Sources/FIRMessagingPubSub.m-  if (error) {
FirebaseMessaging/Sources/FIRMessagingPubSub.m-    FIRMessagingLoggerError(kFIRMessagingMessageCodePubSubArchiveError,
FirebaseMessaging/Sources/FIRMessagingPubSub.m-                            @"Failed to archive topic list data %@", error);
FirebaseMessaging/Sources/FIRMessagingPubSub.m-    return;
FirebaseMessaging/Sources/FIRMessagingPubSub.m-  }
--
FirebaseMessaging/Sources/FIRMessagingPubSub.m:    subscriptions = [GULSecureCoding
FirebaseMessaging/Sources/FIRMessagingPubSub.m-        unarchivedObjectOfClasses:[NSSet setWithObjects:FIRMessagingPendingTopicsList.class, nil]
FirebaseMessaging/Sources/FIRMessagingPubSub.m-                         fromData:pendingData
FirebaseMessaging/Sources/FIRMessagingPubSub.m-                            error:&error];
FirebaseMessaging/Sources/FIRMessagingPubSub.m-    if (error) {
FirebaseMessaging/Sources/FIRMessagingPubSub.m-      FIRMessagingLoggerError(kFIRMessagingMessageCodePubSubUnarchiveError,

API Proposal

No response

Firebase Product(s)

Messaging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants