Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong data with multiple streams established simultaneously #47692

Open
marcus-cheng opened this issue Sep 2, 2020 · 1 comment
Open

Wrong data with multiple streams established simultaneously #47692

marcus-cheng opened this issue Sep 2, 2020 · 1 comment

Comments

@marcus-cheng
Copy link

Hi, I'm facing an issue where multiple streams with different grip-channel will receive data of other grip channel. It won't happen on the initial connection, instead it happens when pushpin calls the url in grip-link returned by the initial connection, and when both stream are established in nearly same time.
My header is like this
"Grip-Channel": "1076063"
"Grip-Link": "</stream/subscribe/transaction?id=01EH2>; rel=next"

I've tried on pushpin, as well as fanout hacker plan. Both are able to simulate this issue.

Any idea why? Thanks.

@jkarneges
Copy link
Member

Hi Marcus,

Pushpin does "request collapsing" if it would need to request the same link on behalf of multiple connections. Also, any GRIP instructions in the response to that request will be applied to the connections. Could it be that you're responding with the wrong Grip-Channel header(s) in the link response, causing the subscribed channels to change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants