Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grip-Channel prev-id with SSE (stream hold mode)? #47677

Open
matrey opened this issue Aug 6, 2019 · 1 comment
Open

Grip-Channel prev-id with SSE (stream hold mode)? #47677

matrey opened this issue Aug 6, 2019 · 1 comment

Comments

@matrey
Copy link

matrey commented Aug 6, 2019

https://pushpin.org/docs/protocols/grip/ states that prev-id only works for response hold mode

Grip-Hold: The hold mode, either response or stream. [...]
Grip-Channel: [...] The prev-id parameter is OPTIONAL and only applies to the response mode.

But then https://pushpin.org/docs/advanced/#reliability shows a code example using prev-id with stream hold mode

Reliable HTTP streaming
When creating a stream hold, any channel to be subscribed must include a prev-id value. A next link must also be provided:

HTTP/1.1 200 OK
Content-Type: text/plain
Grip-Hold: stream
Grip-Channel: fruit; prev-id=3
Grip-Link: </fruit/?after=3>; rel=next

Overall, it seems like the GRIP protocol page is obsolete (e.g. no trace of Grip-Link in it either)

@jkarneges
Copy link
Member

Hi there,

Yes you can use prev-id with stream hold, as part of reliable streaming as you've found.

The spec has been kept lean on purpose, as a conservative starting point for a potential shared standard. Of course it would be nice to have a spec page that covers everything. We'll look into making this better.

In the meantime, if you have other protocol questions feel free to ask!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants