-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: close dialog and show toast for Export image #8007
base: master
Are you sure you want to change the base?
feat: close dialog and show toast for Export image #8007
Conversation
Save to feature closes dialog and showed toast message after exporting successful. Export image feature better follow the same flow.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yongjoon-km for the contribution
Can you also add a toast when copyToClipboard
is clicked?
Hi @ad1992 , I also apply a toast to the Copy to clipboard. Thank you~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yongjoon-km looks good ❤️
I feel the toast stays for too lon, should we reduce the duration ?
cc @dwelle
The default duration of the toast is 5 seconds. excalidraw/packages/excalidraw/components/App.tsx Lines 1963 to 1972 in 4dc975c
|
Change the toast duration from 5 seconds to 1.5 seconds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yongjoon-km looking good ✨
I pushed minor tweaks to simplify, let me know if its good
Thanks~! it looks good 👍 |
hey @yongjoon-km. Sorry for jumping into this late. To give a bit more context, we've had a request for this once already I believe and there were two reasons why we're not closing the export dialog:
|
That said, no matter if we close the dialog or not, you're making a fair point that the we don't indicate clearly that the saved was successful. |
Hello @dwelle , Thanks for pointing out previous history on this~ I tried to reproduce large file exporting by delaying inside the |
Save to feature closes dialog and showed toast message after exporting successful.
Export image feature better follow the same flow.
resolves #8008