Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown search does not work #1971

Open
fboerman opened this issue May 4, 2024 · 2 comments
Open

Dropdown search does not work #1971

fboerman opened this issue May 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@fboerman
Copy link

fboerman commented May 4, 2024

Steps To Reproduce

create a dropdown with some options from a sql query. observe that search does not work. this is with latest version (34)

Environment

  • Node version (node -v): v20.12.2
  • npm version (npm -v): 10.5.2
  • OS: archlinux
  • Browser: firefox (but unrelated)
  • Database: csv (but unrelated)

Expected Behavior

search should filter the options

Actual Behaviour

it does either nothing or removes all options

Workarounds

none found so far, just straight up broken

@fboerman fboerman added bug Something isn't working to-review Evidence team to review labels May 4, 2024
@ItsMeBrianD
Copy link
Member

This is likely fixed by #1980; I haven't been able to get a repro, if there is one available would love to dig into it

@mcrascal mcrascal removed the to-review Evidence team to review label May 15, 2024
@mcrascal
Copy link
Member

Dropdown search "works" at 34.0.1, but there is definitely room for improvement.

  1. Search has no effect on manually added DropdownOptions
  2. Keeping selected items at the top of the list while searching is counterintuitive, especially in a multi-select where you might have many items sitting at the top
  3. The actual search function seems far too permissive, I think we need to more aggressively eliminate options. For example, the search Blargghhh should not yield a list of options with Larry Gaish at the top, it should yield no options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants