Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMS sends artist coverArt ID even if there is no cover art #435

Open
splintering opened this issue Mar 15, 2024 · 1 comment
Open

LMS sends artist coverArt ID even if there is no cover art #435

splintering opened this issue Mar 15, 2024 · 1 comment
Labels
Milestone

Comments

@splintering
Copy link

It seems LMS is sending a coverArt ID for artists over the OS API even if the artist has no cover.

This leads to obsolete requests from clients (in my case Symfonium) for the cover art which always and predictably end in a HTTP 404:

2024-03-15 17:48:32.681 Error/ImageCacheManager: Error downloading image [404] - http://192.168.xx.yy:zzzz/rest/getCoverArt.view?id=**ar-11**&u=REDACTED&p=REDACTED&v=1.13.0&c=Symfonium&f=json

I think there is now way for the clients to predict the result, so the proper behaviour would probably be to not send a coverArt ID if no cover art is there?

@epoupon
Copy link
Owner

epoupon commented Mar 15, 2024

Ah yes you are right, I forgot about this problem.
Thanks for reporting!

@epoupon epoupon added the bug label Mar 15, 2024
@epoupon epoupon added this to the v3.52.0 milestone Mar 15, 2024
@epoupon epoupon modified the milestones: v3.52.0, v3.53.0 Apr 20, 2024
@epoupon epoupon modified the milestones: v3.53.0, v3.54.0 May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants