Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Req/Question] Creating and editing playlists from GUI #393

Open
GioF71 opened this issue Dec 13, 2023 · 9 comments
Open

[Feature Req/Question] Creating and editing playlists from GUI #393

GioF71 opened this issue Dec 13, 2023 · 9 comments

Comments

@GioF71
Copy link

GioF71 commented Dec 13, 2023

Hello, I just verified that I can create a playlist using the subsonic api. I see that the response does not contain the id of the newly created playlist. Anyway one can check using the getPlaylists endpoint, but the createPlaylist accepts multiple calls with the same playlist name and will actually create multiple playlists as well. I suppose maybe an error should be returned?

Anyway about the topic, I see I cannot create playlists from the gui other than from an album view.
Maybe other ways of creating playlists are in your roadmap?

Navidrome's gui allows the creation of an empty playlist, then I can add items from basically any view. For example, from an album view, I can add a track to an existing playlist.

Thank you for any feedback!

@epoupon
Copy link
Owner

epoupon commented Dec 13, 2023

Hello,
Indeed it was not mandatory to return the created/updated playlist before 1.13.0. Will add that.
createPlaylist with multiple multiple names should not work, will check that too.

For now, using the UI, you can only create a playlist from the current playqueue (to a new playlist or to erase an existing one).
I never use playlists myself so don't expect improvments on the UI unless someone explicitely makes feature requests (like you did :) )

@GioF71
Copy link
Author

GioF71 commented Dec 13, 2023

Hello, thank you for your feedback. About this part:

createPlaylist with multiple multiple names should not work

I mean creating a playlist with the same name multiple times, not multiple playlist names in the same request. I probably did not explain myself clearly, sorry.
Asking to create a playlist with the same name actually goes through, and multiple playlists with the same name are created:

image

@epoupon
Copy link
Owner

epoupon commented Dec 13, 2023

Oh ok I See. Indeed maybe I misread the API: the existing playlist should be updated

@epoupon
Copy link
Owner

epoupon commented Dec 13, 2023

Well not that sure actually. In LMS's UI (nor in Navidrome's UI), nothing prevent a user from creating several playlists that have the same name.
Similarly, you can create multiple playlists with the same name in navidrome.
And editing a playlist using a name instead of the id sounds very questionable.

@GioF71
Copy link
Author

GioF71 commented Dec 13, 2023

Well in fact the fact that multiple playlists with the same name might exist does not seem bad to me. But for the api, a good thing would be to return the id of the newly created playlist.
Also agreed that editing a playlist should require to provide its id and not merely the name.
Also there is a dedicated method for modifying a playlist (updatePlaylist), and that requires the playlistId :-)

Edit: completed / typo

@epoupon
Copy link
Owner

epoupon commented Dec 13, 2023

Yes, that was I did in 5257f68
I keep this open to improve playlist editions from UI (like in the title )

@GioF71
Copy link
Author

GioF71 commented Dec 13, 2023

Awesome! So there is a build coming with that tag?

EDIT: yes I see there are actions running right now

@epoupon
Copy link
Owner

epoupon commented Dec 13, 2023

There is no docker image pushed by default, but I can build one manually if you really need to test (beware the current dev branch embeds some schema updates)

@GioF71
Copy link
Author

GioF71 commented Dec 13, 2023

Hello, no I believe there is no rush, thank you anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants