Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDS metadata keys should be filter instance names, not filter implementation names #34251

Open
markdroth opened this issue May 20, 2024 · 0 comments
Labels
area/gcp_authn area/http_filter enhancement Feature requests. Not bugs or questions.

Comments

@markdroth
Copy link
Contributor

In #12274, we changed the keys in typed_per_filter_config to match the HTTP filter instance name (the HttpFilter.name field) instead of the legacy filter implementation name (e.g., "envoy.filters.http.gcp_authn"). However, the CDS metadata keys are still using the legacy names (example).

I think we should make the same change for CDS metadata keys that we did for typed_per_filter_config, so that it becomes possible to specify different metadata for multiple instances of the same filter.

@markdroth markdroth added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels May 20, 2024
@zuercher zuercher added area/http_filter area/gcp_authn and removed triage Issue requires triage labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gcp_authn area/http_filter enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

2 participants