-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor/renameSymbol
method does not update buffer of opened module.
#9960
Comments
I've assigned |
Maybe it was supposed to be like that, but right now the |
There is another potential issue. The |
Dmitry Bushev reports a new STANDUP for today (2024-05-17): Progress: Updated the file/read method to return the contents of a collaborative buffer if it was opened for the corresponding file. Added tests. Created a PR. It should be finished by 2024-05-22. Next Day: Next day I will be working on the #9960 task. Continue working on the task |
part of #9960 Changelog: - feat: file/read return contents of a collaborative buffer if they are available and fallback to reading the file from disk
The fix for the |
Regarding IdMap; our ydocs server (after a few tweaks) handles the idmap changes if received a code-only update. Thus, the task #9790 is no longer blocked. For me, this task may be closed - we want to remove idmaps from files anyway. |
Ok, closing this one |
In this branch there is IDE with "rename local method" feature. It calls
refactor/rename
method of language server and - whentext/didChange
message arrives - it reloads file usingfile/read
method.But
file/read
method returns the old state of the file, despite the documentation which says:To reproduce:
wip/farmaazon/rename-functions
npm --workspace enso-gui2 run dev
collapsed
name in calling node. Note - if you cannot edit the name, then probably the local methods haven't been loaded to suggestion db due to some bug. Try restarting application (including PM).First we receive "did change" message with proper diff, but then, from
file/read
we receive old file.The text was updated successfully, but these errors were encountered: