Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @ember/runloop in test blueprints #20690

Open
mkszepp opened this issue May 3, 2024 · 0 comments
Open

Remove @ember/runloop in test blueprints #20690

mkszepp opened this issue May 3, 2024 · 0 comments

Comments

@mkszepp
Copy link
Contributor

mkszepp commented May 3, 2024

After removing all @ember/runloop from my app i have discovered that new test blueprints are bringing again the lint warnings.

By using the command ember g instance-initializer my-init or also ember g initializer my-init (maybe also other blueprints) we are getting non recommended codes inside the app.

The blueprints should be refactored, so that they don't bring anymore @ember/runloop.

import Application from '@ember/application';
import config from '<%= modulePrefix %>/config/environment';
import { initialize } from '<%= modulePrefix %>/instance-initializers/<%= dasherizedModuleName %>';
import { module, test } from 'qunit';
import Resolver from 'ember-resolver';
<% if (destroyAppExists) { %>import destroyApp from '../../helpers/destroy-app';<% } else { %>import { run } from '@ember/runloop';<% } %>
module('<%= friendlyTestName %>', function (hooks) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant