Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB Endpoint struct is no longer Send #2957

Closed
mattico opened this issue May 17, 2024 · 1 comment · Fixed by #2971
Closed

USB Endpoint struct is no longer Send #2957

mattico opened this issue May 17, 2024 · 1 comment · Fixed by #2971

Comments

@mattico
Copy link
Contributor

mattico commented May 17, 2024

Previously at least <embassy_stm32::usb::Driver<'d, USB_OTG_HS> as Driver<'d>>::EndpointIn was Send, but after #2881 it contains an UnsafeCell<*mut u8> and therefore isn't Send. Perhaps we just need an unsafe impl Send for Endpoint<_> but I haven't thought carefully about whether that's safe or not.

@Dirbaio
Copy link
Member

Dirbaio commented May 18, 2024

maybe unsafe impl Send/Sync for EpState is a less heavy hammer and should still do it. the previous code already had that for State.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants