Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove $fileExists condition before CheckSum #724

Closed
wants to merge 2 commits into from
Closed

Remove $fileExists condition before CheckSum #724

wants to merge 2 commits into from

Conversation

XVII
Copy link

@XVII XVII commented Jul 5, 2021 •
edited

Pull Request (PR) description

Test the CheckSum if it's provided -- allow it to override cached attribute check.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 5, 2021 •
edited

Codecov Report

Merging #724 (eb7f67d) into main (475885c) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           main   #724     +/-   ##
=====================================
- Coverage    72%    72%     -1%     
=====================================
  Files        30     30             
  Lines      4427   5838   +1411     
=====================================
+ Hits       3213   4209    +996     
- Misses     1214   1629    +415
Impacted Files Coverage Δ
.../DSCResources/DSC_xRemoteFile/DSC_xRemoteFile.psm1 89% <ø> (ø)
...ces/DSC_xPackageResource/DSC_xPackageResource.psm1 78% <0%> (-2%) ⬇️
...sources/DSC_xGroupResource/DSC_xGroupResource.psm1 69% <0%> (-1%) ⬇️
...xEnvironmentResource/DSC_xEnvironmentResource.psm1 91% <0%> (-1%) ⬇️
...ces/DSC_xServiceResource/DSC_xServiceResource.psm1 93% <0%> (-1%) ⬇️
...Resources/DSC_xUserResource/DSC_xUserResource.psm1 53% <0%> (-1%) ⬇️
...urces/DSC_xScriptResource/DSC_xScriptResource.psm1 100% <0%> (ø)
...sionConfiguration/DSC_xPSSessionConfiguration.psm1 0% <0%> (ø)
...urces/DSC_xWindowsFeature/DSC_xWindowsFeature.psm1 88% <0%> (+1%) ⬆️

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jul 10, 2021
@PlagueHO
Copy link
Member

/AzurePipeline run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@XVII XVII closed this by deleting the head repository May 7, 2023
@brwilkinson brwilkinson mentioned this pull request Aug 2, 2023
Open
@johlju johlju added closed by author The issue or pull request was closed by the author. and removed needs review The pull request needs a code review. labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
closed by author The issue or pull request was closed by the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a file exists, and matches checksum, the cache still considers it invalid
3 participants
@XVII @PlagueHO @johlju