Interface number - Fixes #382 #424
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #424 +/- ##
===================================
Coverage 95% 95%
===================================
Files 28 28
Lines 2281 2281
===================================
Hits 2178 2178
Misses 103 103 |
|
It looks like this tests are failing @Outek |
|
Yes i know @PlagueHO , if i run the unit tests locally everything is green... |
|
HI @Outek - I'll try and get some time to have a look and see if I can figure out what is going on. Going to be really short on time for a little bit unfortunately as I have to sit a couple of exams shortly. |
|
Hi @Outek - can you rebase this onto the latest upstream Dev commit? It should fix the style issues. I'll then take a look at the other test failures. |
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 3 of 4 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Outek)
Modules/NetworkingDsc.Common/NetworkingDsc.Common.psm1, line 607 at r3 (raw file):
# Return a null so that ErrorAction SilentlyContinue works correctly $IgnoreMultipleMatchingAdapters = $true
$IgnoreMultipleMatchingAdapters is a [Switch] type, not a boolean. So you can't assign a boolean to it.
Instead, you can:
$IgnoreMultipleMatchingAdapters = [Switch]::Present
Modules/NetworkingDsc.Common/NetworkingDsc.Common.psm1, line 609 at r3 (raw file):
$IgnoreMultipleMatchingAdapters = $true } else {
The { should be on the next line.
Modules/NetworkingDsc.Common/NetworkingDsc.Common.psm1, line 610 at r3 (raw file):
} else { $IgnoreMultipleMatchingAdapters = $_.IgnoreMultipleMatchingAdapters
I'm not sure what this line is doing? Is it needed?
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, 3 unresolved discussions (waiting on @PlagueHO)
Modules/NetworkingDsc.Common/NetworkingDsc.Common.psm1, line 607 at r3 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
$IgnoreMultipleMatchingAdaptersis a [Switch] type, not a boolean. So you can't assign a boolean to it.Instead, you can:
$IgnoreMultipleMatchingAdapters = [Switch]::Present
Done.
Modules/NetworkingDsc.Common/NetworkingDsc.Common.psm1, line 609 at r3 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
The { should be on the next line.
Done.
Modules/NetworkingDsc.Common/NetworkingDsc.Common.psm1, line 610 at r3 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
I'm not sure what this line is doing? Is it needed?
Done.
|
Sorry @Outek - looks like I missed this repo when we were correcting the hashtable format. So I'm going to submit a PR to fix that. |
|
Hi @Outek - I've fixed the issues with the Hashtable format, so you should be able to rebase onto Dev and resolve the conflicts which should fix the CI failures. I'll then review. Sorry about the delay. |
|
Hi @Outek - are you still keen to complete this? |
PlagueHO
added
abandoned
|
I think i have to start over, i deleted my Fork. |
Pull Request (PR) description
Fixed Network Adapter renaming
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is