Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-LocalizedDataRecursive: Exception is never thrown when $BaseDirectory is not passed #17

Open
johlju opened this issue May 14, 2024 · 0 comments
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Member

johlju commented May 14, 2024

Should this line be elseif (-not [System.String]::IsNullOrEmpty($BaseDirectory)) to solve that the throw statement is never reached?

elseif ($null -ne $BaseDirectory)

It looks like the line should be changed to what is suggested above, but that will fail the test, and looking at this it need to be looked at further to see if it should be refactored in some way depending on how the function is used from the classes (how ImportLocalization() is used).

@johlju johlju changed the title Get-LocalizedDataRecursive: Exception is never thrown when $BaseDirectory is $null Get-LocalizedDataRecursive: Exception is never thrown when $BaseDirectory is not passed May 14, 2024
@johlju johlju added bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

No branches or pull requests

1 participant