Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: finalize replacements for Deno.fdatasync[Sync]() and Deno.fsync[Sync]() #22230

Closed
iuioiua opened this issue Feb 2, 2024 · 2 comments · Fixed by #23733
Closed

suggestion: finalize replacements for Deno.fdatasync[Sync]() and Deno.fsync[Sync]() #22230

iuioiua opened this issue Feb 2, 2024 · 2 comments · Fixed by #23733
Assignees
@bartlomieju

Comments

@iuioiua
Copy link
Collaborator

iuioiua commented Feb 2, 2024

The following I/O APIs should be replaced with Deno.FsFile methods. This has partially been done already. However, we haven't been able to finalize the new API names, as indicated in #22085.

  1. Deno.fdatasync[Sync]() (currently Deno.FsFile.syncData[Sync]())
  2. Deno.fsync[Sync]() (currently Deno.FsFile.sync[Sync])
@iuioiua iuioiua changed the title suggestion: finalize replacements for I/O + file system APIs suggestion: finalize replacements for Deno.fdatasync[Sync]() and Deno.fsync[Sync]() Feb 2, 2024
@bartlomieju bartlomieju self-assigned this Mar 14, 2024
@dyedgreen
Copy link
Contributor

Are there any plans for stabilizing these (and the file locking) APIs?

This is blocking deno sqlite from upgrading to the new API: dyedgreen/deno-sqlite#259

@iuioiua iuioiua mentioned this issue May 8, 2024
Merged
@iuioiua
Copy link
Collaborator Author

iuioiua commented May 8, 2024

We're stabilizing these APIs in the next minor release in #23733.

bartlomieju pushed a commit that referenced this issue May 22, 2024
@iuioiua
feat(ext/fs): stabilize Deno.FsFile.syncData[Sync]() and `Deno.FsFi…
6c167c6 
…le.sync[Sync]()` (#23733)

Closes #22230
@iuioiua iuioiua mentioned this issue May 22, 2024
Merged
iuioiua added a commit that referenced this issue May 22, 2024
@iuioiua
feat(ext/fs): stabilize Deno.FsFile.unlock[Sync]() and `Deno.FsFile…
4908d45 
….lock[Sync]()` (#23754)

Related #22230
CC @dyedgreen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlomieju bartlomieju

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ext/fs): stabilize Deno.FsFile.syncData[Sync]() and Deno.FsFile.sync[Sync]() iuioiua/deno
3 participants
@dyedgreen @bartlomieju @iuioiua