Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for modular installation #69

Open
denis-stepanov opened this issue Apr 12, 2024 · 1 comment
Open

Support for modular installation #69

denis-stepanov opened this issue Apr 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@denis-stepanov
Copy link
Owner

denis-stepanov commented Apr 12, 2024

TV control plugins require very different dependencies, and most likely only one of them would be needed for a given user. Currently, AdVent is packaged as a single package, meaning it installs dependencies of all supported TV controls, whether you want it or not. It would be good to partition into a structure like:

  • advent
  • advent-pulseaudio
  • advent-harmonyhub
  • advent-broadlink
  • ...

It would then be logical to change the default TV control from PulseAudio to Nil.

@denis-stepanov denis-stepanov added the enhancement New feature or request label Apr 12, 2024
@denis-stepanov
Copy link
Owner Author

In an unlikely event of changing a recognition provider, the provider adapter packages would be called something like advent-rec-dejavu, which would mean that TV controls better be called as advent-tv-pulseaudio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant