Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code editor syntax highlighting bug #23116

Closed
saikotek opened this issue Mar 13, 2024 · 5 comments · Fixed by #29903
Closed

Code editor syntax highlighting bug #23116

saikotek opened this issue Mar 13, 2024 · 5 comments · Fixed by #29903
Assignees
@E1izabeth @uslss
Labels
bug sp:2 x:mysql xf:sql editor SQL Editor and Editor Services like autocompletion, highlighting, folding, formatting, etc.
Milestone
24.0.5

Comments

@saikotek
Copy link
Contributor

Description

Hello, I have similar problem to #22302
Some fields in code editor are underlined in red color:
dbeaver_Pdv499Acf1
But this query runs perfectly fine.

Error.log:
error.log

DBeaver Version

Community Edition 24.0.0.202403091004

Operating System

Windows 11 Home

Database and driver

Database: MySQL 8.3.0
Driver: mysql8 (MySQL Connector J 8.2.0)
dbeaver_XBTggytEAg

Steps to reproduce

  1. I connect to database
  2. Open saved query or write new query in code editor

Additional context

Code completion sees the field that is highlighted.
SjjmJ3TFDj

I tried restarting settings.
@LonwoLonwo LonwoLonwo added the xf:sql parser Syntax analyzer label Mar 13, 2024
@LonwoLonwo
Copy link
Member

Hello @saikotek

Could you please provide your tables DDLs? For testing.

@saikotek
Copy link
Contributor Author

Hello @LonwoLonwo
Yes, I think I found where is the problem. Check out the DDL I attached.

dump-test_null-202403131722.txt

It seems that the problem arises when the table name is a MySQL keyword (therefore you need to query it with backticks)
dbeaver_ejvG134OGT

@E1izabeth
Copy link
Member

It's a duplicate of #23020

@E1izabeth E1izabeth removed their assignment Mar 14, 2024
@E1izabeth E1izabeth removed the xf:sql parser Syntax analyzer label Mar 14, 2024
@LonwoLonwo LonwoLonwo added xf:sql editor SQL Editor and Editor Services like autocompletion, highlighting, folding, formatting, etc. x:mysql labels Apr 3, 2024
@E1izabeth
Copy link
Member

E1izabeth commented May 6, 2024 •
edited

Does it still reproducible? I can't reproduce the issue.

UPDATED: never mind, reproduces with connection turned off

E1izabeth added a commit that referenced this issue May 6, 2024
@E1izabeth
#23116 Fix quoted identifier context when no connection
48d402d
@E1izabeth E1izabeth linked a pull request May 6, 2024 that will close this issue
#23116 Fix quoted identifier context when no connection #29903
Merged
@arhayka arhayka added this to the 24.0.5 milestone May 6, 2024
@uslss uslss self-assigned this May 8, 2024
@Yigitttttttt
Copy link

I have same bug on ORACLE

serge-rider pushed a commit that referenced this issue May 10, 2024
@E1izabeth
#23116 Fix quoted identifier context when no connection (#29903)
f076c2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@E1izabeth E1izabeth

@uslss uslss

Labels
bug sp:2 x:mysql xf:sql editor SQL Editor and Editor Services like autocompletion, highlighting, folding, formatting, etc.
Projects
None yet
Milestone
24.0.5
Development

Successfully merging a pull request may close this issue.

#23116 Fix quoted identifier context when no connection dbeaver/dbeaver
6 participants
@saikotek @arhayka @E1izabeth @uslss @LonwoLonwo @Yigitttttttt