Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert error for aliased constructors in annotations #55755

Closed
johnniwinther opened this issue May 17, 2024 · 0 comments
Closed

Assert error for aliased constructors in annotations #55755

johnniwinther opened this issue May 17, 2024 · 0 comments
Assignees
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cfe-dysfunctionalities Issues for the CFE not behaving as intended

Comments

@johnniwinther
Copy link
Member

These annotations

class Class {
  const Class([a]);
  const Class.named({a, b});
}

class GenericClass<X, Y> {
  const GenericClass();
  const GenericClass.named({a, b});
}

typedef Alias = Class;
typedef ComplexAlias<X> = Class;
typedef GenericAlias<X, Y> = GenericClass<X, Y>;

@Class(Alias.named())
@Class(ComplexAlias())
@Class(ComplexAlias.named())
@Class(GenericAlias())
@Class(GenericAlias.named())
void type() {}

cause assertion errors like
'package:front_end/src/fasta/kernel/body_builder.dart': Failed assertion: line 1100 pos 11: 'delayedActionPerformers != null': Body builder has delayed actions that cannot be performed: [TypeAliasedConstructorInvocation(const Alias.named())]

@johnniwinther johnniwinther added area-front-end Use area-front-end for front end / CFE / kernel format related issues. cfe-dysfunctionalities Issues for the CFE not behaving as intended labels May 17, 2024
copybara-service bot pushed a commit that referenced this issue Jun 10, 2024
…ssing"

This reverts commit d31d0f9.

Reason for revert: The CL breaks some tests in google3.

Original change's description:
> [cfe] Account for compilation stage in invocations post-processing
>
> Closes #55849
> Closes #55755
>
> Change-Id: I471830cafed76ec5c503fe726ade857c007ed712
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369063
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>

Change-Id: Ia0fa3002a46352b15f42166188c32821897841ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370480
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
copybara-service bot pushed a commit that referenced this issue Jun 11, 2024
…sing

Closes #55849
Closes #55755

This is a reland of https://dart-review.googlesource.com/c/sdk/+/369063

Change-Id: I9033935b3b352108c8c28b7ae09eaa9673b0a6fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370560
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cfe-dysfunctionalities Issues for the CFE not behaving as intended
Projects
None yet
Development

No branches or pull requests

2 participants