Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests break when run under the pwsh 7.3 #950

Open
DominikJaniec opened this issue Mar 2, 2023 · 0 comments
Open

Tests break when run under the pwsh 7.3 #950

DominikJaniec opened this issue Mar 2, 2023 · 0 comments

Comments

@DominikJaniec
Copy link

Currently, tests here are executed within PowerShell 7.2.9.

However, when one executes tests within PowerShell 7.3.3, a few tests using test-vsts-pr alias are failing. I believe it is because of breaking feature toggle: $PSNativeCommandArgumentPassing.

Basically, it prevents pwsh from stripping the " characters from strings passed into executables:

echo.exe "test `"str`""
powershell> $PSVersionTable.PSVersion
Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      19041  2364

powershell> $text = "test `"str`""
powershell> Write-Host $text
test "str"
powershell> echo.exe $text
test str
pwsh> $PSVersionTable.PSVersion
Major  Minor  Patch
-----  -----  -----
7      3      3

pwsh> $text = "test `"str`""
pwsh> Write-Host $text
test "str"
pwsh> echo.exe $text
test "str"

I'll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant