Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate advices from tricks #56

Open
taylankasap opened this issue Jan 31, 2023 · 2 comments
Open

Separate advices from tricks #56

taylankasap opened this issue Jan 31, 2023 · 2 comments

Comments

@taylankasap
Copy link

Repo name is go advice so I was thinking these are advices. But repo description says advice and tricks.

For example, is this an advice?

  • check interface implementation during compilation
var _ io.Reader = (*MyFastReader)(nil)

Or does it just mean "if you need to check interface implementation during compilation, then do this", if so this makes it a trick, not an advice.

Unfortunately I'm not sure which is which so I can't open a PR. But IMO there should be a separation.

@cristaloleg
Copy link
Owner

You're too strict to the repo name.

Repo called blabla doesn't mean it's about "bla bla", it might be literally anything. Similar situation with go-advice.

It's not only advices but also a useful patterns that are not so obvious for the new gophers.

I don't think that removing "tricks" from repo description will change something. Curious to hear wdyt. Thx.

@taylankasap
Copy link
Author

@cristaloleg sorry I think I wasn't clear. I meant separation in this repo itself, e.g. 2 sections in the readme. Not a separate repo.

I agree with you on repo name not meaning much. But I thought these were all advices until after I read the description. Others might make the same mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants