Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 Elantra car Unrecognized #32353

Open
1okko opened this issue May 6, 2024 · 17 comments · May be fixed by #30219
Open

2024 Elantra car Unrecognized #32353

1okko opened this issue May 6, 2024 · 17 comments · May be fixed by #30219
Labels
bug car vehicle-specific

Comments

@1okko
Copy link

1okko commented May 6, 2024

Describe the bug

2024 Elantra car Unrecognized

Which car does this affect?

2024 HYUNDAI Elantra

Provide a route where the issue occurs

d01e5725e5587ae3/00000001--a4126f0d93/0

openpilot version

0.9.7

Additional info

It can be confirmed that the vehicle is a CAN and a camera SCC

@1okko 1okko added bug car vehicle-specific labels May 6, 2024
@sshane
Copy link
Contributor

sshane commented May 6, 2024

Has a CAN FD radar bus. Please try this branch: https://github.com/commaai/openpilot/tree/cn7c-elantra

@1okko
Copy link
Author

1okko commented May 7, 2024

ok.i will try and let you know.

@1okko
Copy link
Author

1okko commented May 8, 2024

d01e5725e5587ae3/00000000--178533cb2e/1

it works well,thanks

@1okko
Copy link
Author

1okko commented May 8, 2024

拥有CAN FD雷达总线。请尝试这个分支:https://github.com/commaai/openpilot/tree/cn7c-elantra

d01e5725e5587ae3/00000000--178533cb2e/1

效果很好,谢谢

@1okko
Copy link
Author

1okko commented May 8, 2024

d01e5725e5587ae3/00000000--178533cb2e/1

it works well,thanks

d01e5725e5587ae3/00000000--178533cb2e/1

it works well,thanks

@sshane
Copy link
Contributor

sshane commented May 8, 2024

Nice! Can you drive more to gather more lateral control data? I'll get #30219 cleaned up and merged shortly after once we verify that lateral control is as we expect (not too much or too little lateral acceleration)

@sshane sshane linked a pull request May 8, 2024 that will close this issue
@1okko
Copy link
Author

1okko commented May 8, 2024

d01e5725e5587ae3/00000000--178533cb2e/1

d01e5725e5587ae3/00000000--178533cb2e/1 this not enough?

@sshane
Copy link
Contributor

sshane commented May 9, 2024

Need some more curves I believe!

@1okko
Copy link
Author

1okko commented May 9, 2024

Need some more curves I believe!

ok, i will drive it today

@1okko
Copy link
Author

1okko commented May 10, 2024

Need some more curves I believe!

d01e5725e5587ae3/00000002--3ec9e0ec2a/0

@sshane
Copy link
Contributor

sshane commented May 11, 2024

High speed (> 80 km/h) and engaged curves I mean

@sshane
Copy link
Contributor

sshane commented May 22, 2024

@1okko can you get more driving data please? Then we can merge!

@1okko
Copy link
Author

1okko commented May 25, 2024

@1okko can you get more driving data please? Then we can merge!

d01e5725e5587ae3/00000003--ecb5e1500a/2

@sshane
Copy link
Contributor

sshane commented May 25, 2024

Dongle, platform, VIN Name from VIN 🆚 CarDocs Segments Bad seg tags Good seg tags
d01e5725e5587ae3
HYUNDAI_ELANTRA_2021
000000000........
None 🆚
None
4 routes,
94 segments
(1.6 hours)
- all lat active: 51
- no input all lat active: 42

@sshane
Copy link
Contributor

sshane commented May 25, 2024

Need a little more sharper turns at high speeds, the torqued learner doesn't have many data points there.

@1okko
Copy link
Author

1okko commented May 25, 2024

Need a little more sharper turns at high speeds, the torqued learner doesn't have many data points there.

ok

@1okko
Copy link
Author

1okko commented Jun 1, 2024

Need a little more sharper turns at high speeds, the torqued learner doesn't have many data points there.

d01e5725e5587ae3/00000004--9eae7430ad/0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug car vehicle-specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants