Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-3672] Timezone dependent unit tests fail when not on UTC #14964

Open
zomars opened this issue May 9, 2024 · 0 comments
Open

[CAL-3672] Timezone dependent unit tests fail when not on UTC #14964

zomars opened this issue May 9, 2024 · 0 comments
Labels
automated-tests area: unit tests, e2e tests, playwright 🐛 bug Something isn't working High priority Created by Linear-GitHub Sync
Milestone

Comments

@zomars
Copy link
Member

zomars commented May 9, 2024

Many of the European team folk wont face this issue. But the American team cannot consistently run unit tests locally. We get 4 or 5 failed tests. To replicate, try running tests with the MST timezone (the current TZ I have):

TZ=MST yarn test

image.png

If I try running from UTC then all errors go away:

 TZ=UTC yarn test

image.png

IMO all testing should be time zone agnostic. If we're testing TZ changes we should mock and clean them up properly. But the machine where the tests are ran from should not interfere with the results.

From SyncLinear.com | CAL-3672

@zomars zomars added the High priority Created by Linear-GitHub Sync label May 9, 2024
@dosubot dosubot bot added automated-tests area: unit tests, e2e tests, playwright 🐛 bug Something isn't working labels May 9, 2024
@zomars zomars added 🐛 bug Something isn't working and removed 🐛 bug Something isn't working labels May 9, 2024
@zomars zomars added this to the v4.2 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright 🐛 bug Something isn't working High priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant