Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-3670] i18n: German translations missing from the booking and success page #14953

Open
milospuac opened this issue May 9, 2024 · 2 comments
Labels
i18n area: i18n, translations Low priority Created by Linear-GitHub Sync

Comments

@milospuac
Copy link
Contributor

Screenshot 2024-05-09 at 10.27.15.png

From SyncLinear.com | CAL-3670

Copy link

dosubot bot commented May 9, 2024

To address the issue of missing German translations on the booking and success pages, you can automate the verification process using Playwright. Here's a concise guide to ensure your web interface correctly displays German translations, including maintaining an informal communication style:

  1. Set Playwright to German Locale: Configure your Playwright tests to operate in the German locale with locale: "de" to simulate the user environment accurately.

  2. Navigate and Verify Pages: Use page.goto() to navigate to the booking and success pages. Ensure the pages fully load by waiting for the domcontentloaded event.

  3. Check HTML Attributes: Verify the html tag includes lang="de" and dir="ltr" to ensure the page is correctly set for German and left-to-right text direction.

  4. Validate Translations: Employ Playwright's text selectors, like getByText or getByRole, to check for accurate German translations of static texts, dynamic fields (event titles, dates, email addresses), and ensure the informal tone is captured in phrases and sentences.

  5. Apply to Both Pages: Repeat these checks for both the booking and success pages to confirm consistency across your interface.

This approach helps automate the testing of German translations, ensuring a seamless and correctly localized user experience. For detailed implementation, refer to the locale.e2e.ts and common.json files for examples on setting up your tests.

Details

Sources


About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

@dosubot dosubot bot added the i18n area: i18n, translations label May 9, 2024
@smitgol
Copy link

smitgol commented May 9, 2024

i am sure about the time format but there is already pr raised for translation

@ciaranha ciaranha added the Low priority Created by Linear-GitHub Sync label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n area: i18n, translations Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

3 participants