Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added BAA to App Store #14894

Merged
merged 2 commits into from May 16, 2024
Merged

Conversation

PeerRich
Copy link
Member

@PeerRich PeerRich commented May 6, 2024

CleanShot 2024-05-06 at 12 39 21@2x

@PeerRich PeerRich linked an issue May 6, 2024 that may be closed by this pull request
Copy link

linear bot commented May 6, 2024

@graphite-app graphite-app bot requested a review from a team May 6, 2024 10:39
@github-actions github-actions bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

graphite-app bot commented May 6, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@dosubot dosubot bot added the ✨ feature New feature or request label May 6, 2024
@PeerRich PeerRich added the ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work label May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented May 6, 2024

Current Playwright Test Results Summary

✅ 317 Passing - ⚠️ 18 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/06/2024 10:54:23am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 1ea9a0d

Started: 05/06/2024 10:51:41am UTC

⚠️ Flakes

📄   apps/web/playwright/teams.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 1Initial Attempt
8.39% (24) 24 / 286 runs
failed over last 7 days
26.57% (76) 76 / 286 runs
flaked over last 7 days
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 1Initial Attempt
15.38% (44) 44 / 286 runs
failed over last 7 days
22.73% (65) 65 / 286 runs
flaked over last 7 days
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 1Initial Attempt
7.28% (19) 19 / 261 runs
failed over last 7 days
28.74% (75) 75 / 261 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load if correct embedLibUrl is provided
Retry 1Initial Attempt
0% (0) 0 / 67 runs
failed over last 7 days
32.84% (22) 22 / 67 runs
flaked over last 7 days

📄   apps/web/playwright/hash-my-url.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
hash my url generate url hash
Retry 2Retry 1Initial Attempt
6.17% (15) 15 / 243 runs
failed over last 7 days
31.28% (76) 76 / 243 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address
Retry 1Initial Attempt
0% (0) 0 / 281 runs
failed over last 7 days
16.01% (45) 45 / 281 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes

Top 1 Common Error Messages

null

9 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
11.19% (31) 31 / 277 runs
failed over last 7 days
51.26% (142) 142 / 277 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-136.54% (-142) -142 / 104 runs
failed over last 7 days
136.54% (142) 142 / 104 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-137.86% (-142) -142 / 103 runs
failed over last 7 days
137.86% (142) 142 / 103 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-134.95% (-139) -139 / 103 runs
failed over last 7 days
134.95% (139) 139 / 103 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-134.95% (-139) -139 / 103 runs
failed over last 7 days
134.95% (139) 139 / 103 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-134.95% (-139) -139 / 103 runs
failed over last 7 days
134.95% (139) 139 / 103 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-134.95% (-139) -139 / 103 runs
failed over last 7 days
134.95% (139) 139 / 103 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-134.95% (-139) -139 / 103 runs
failed over last 7 days
134.95% (139) 139 / 103 runs
flaked over last 7 days
Popup Tests should open on clicking child element
Retry 1Initial Attempt
-137.37% (-136) -136 / 99 runs
failed over last 7 days
137.37% (136) 136 / 99 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
12.21% (32) 32 / 262 runs
failed over last 7 days
30.15% (79) 79 / 262 runs
flaked over last 7 days

📄   apps/web/playwright/organization/booking.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Bookings Team Event Can create a booking for Round Robin EventType
Retry 1Initial Attempt
15.41% (43) 43 / 279 runs
failed over last 7 days
24.37% (68) 68 / 279 runs
flaked over last 7 days

📄   packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1Initial Attempt
16.30% (45) 45 / 276 runs
failed over last 7 days
39.49% (109) 109 / 276 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode added this to the v4.1 milestone May 8, 2024
@keithwillcode keithwillcode modified the milestones: v4.1, v4.2 May 15, 2024
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 lgtm

@emrysal emrysal merged commit ca05e70 into main May 16, 2024
42 checks passed
@emrysal emrysal deleted the 14891-cal-3643-baa-inside-app-store branch May 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar ✨ feature New feature or request ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3643] BAA inside app store
3 participants