Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Can't import wallet file / Electrum and Sparrow #5970

Open
1 task done
Nisaba opened this issue May 3, 2024 · 6 comments
Open
1 task done

[Bug]: Can't import wallet file / Electrum and Sparrow #5970

Nisaba opened this issue May 3, 2024 · 6 comments
Assignees
Milestone

Comments

@Nisaba
Copy link
Contributor

Nisaba commented May 3, 2024

What is your BTCPay version?

BTCPay 1.13.1

How did you deploy BTCPay Server?

Docker

What happened?

I Get this error when I try to import wallet file generated by Electrum or Sparrow :
"Import failed, make sure you import a compatible wallet format"

image

How did you encounter this bug?

Select wallet file (generated by Electrum or Sparrow) then click on Continue

Relevant log output

No response

What browser do you use?

No response

Additional information

No response

Are you sure this is a bug report?

  • I confirm this is a bug report
@nostitos
Copy link

nostitos commented May 6, 2024

Not sure if it'd make a difference but did you follow the export instruction or just used a wallet file?

BTW last I tested that, it would only import the XPUB from the wallet, read only.

@Nisaba
Copy link
Contributor Author

Nisaba commented May 6, 2024

Yes of course, I followed the export instructions

@NicolasDorier NicolasDorier added this to the 1.13.x milestone May 9, 2024
@ndeet
Copy link
Contributor

ndeet commented May 14, 2024

Hey @Nisaba tried to reproduce but it works as expected for me. Did you ensure you exported as electrum compatible json format? Is it a multisig or singlesig? Maybe you can send a test-wallet export?

@Nisaba
Copy link
Contributor Author

Nisaba commented May 14, 2024

The files are not JSON, but encoded files.
So the issue could come from password encryption ?
So maybe a little touch-up on the instructions... Because we could assume that the mention on encrypted protection relates to the backup (which is what I thought) and not initially on the wallet itself. Since wallets are in fact almost always password protected...

@ndeet
Copy link
Contributor

ndeet commented May 14, 2024

We have the instructions right on the import wallet page, it says you need to go to
File -> Export wallet.. -> Electrum: Export file

screenshot-mainnet demo btcpay tech-2024 05 14-15_37_50

It would also work with an additional passphrase afaik. An encrypted wallet backup is something else and would be used to create a hot wallet, the above mentioned import only adds a watch-only wallet. If you want to have a hot wallet you can only do that by entering the seed words.

Can you point out the docs where this is unclear so we can fix it?

@Nisaba
Copy link
Contributor Author

Nisaba commented May 14, 2024

Since the backups generated by Electrum and Sparrow are not json but encoded files, so the issue comes from the password of the wallet.
Just saying that for Electrum, the sentence "(not encrypted with password)" could be understand that the encryption is related to the backup, not the wallet.
And this is not mentioned with Sparrow, whereas the situation is same.

It would also work with an additional passphrase afaik. An encrypted wallet backup is something else and would be used to create a hot wallet, the above mentioned import only adds a watch-only wallet. If you want to have a hot wallet you can only do that by entering the seed words.

-> Maybe this could be added to avoid misunderstanding...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants