Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving reports to its own repository #801

Open
tsalo opened this issue Dec 7, 2021 · 4 comments · May be fixed by #814
Open

Consider moving reports to its own repository #801

tsalo opened this issue Dec 7, 2021 · 4 comments · May be fixed by #814
Labels
question reports Issues/PRs related to the reports module

Comments

@tsalo
Copy link
Member

tsalo commented Dec 7, 2021

The reports module is sort of disconnected from the rest of pybids, and I was thinking that it might be a good idea to move it to its own package (e.g., bids-standard/pybids-reports). I brought this idea up in today's BIDS maintainers meeting, and our decision was to open an issue to give users the opportunity to weigh in on this idea.

A bit of context:

  • The only dependency that reports currently adds is num2words, but @Remi-Gau has proposed using a templating tool to build reports in the future.
  • AFAIK, the reports module is not commonly used, so I assume that removing it from pybids won't cause any major problems for users. Please feel to comment here if that's not the case.
  • Any new library would use pybids as a dependency.
@tsalo tsalo added question reports Issues/PRs related to the reports module labels Dec 7, 2021
@effigies
Copy link
Collaborator

effigies commented Dec 7, 2021

Assuming it is decided to break things out...

Would it make sense to do it as a namespace package, so it would still be imported as bids.reports? This is how we're doing pydra task packages which get imported under pydra.tasks.<package>.

We might be able to do something clever on our end, so that attempting to import without the package installed raises an informative error:

>>> from bids import reports
ImportError("Please install the pybids-reports package with pip")

That should help smooth out any transition, especially if you're able to maintain the API for a few versions at least.

@tsalo
Copy link
Member Author

tsalo commented Dec 9, 2021

I like that idea!

@Remi-Gau
Copy link
Contributor

FYI: I will be playing around with using "mustache" templates to better separate code and boilerplate text in the report module.

For now I am sandboxing things in this repo.

https://github.com/Remi-Gau/bids-methods/blob/main/Demo.ipynb

@tsalo
Copy link
Member Author

tsalo commented Feb 10, 2022

I've created https://github.com/bids-standard/pybids-reports and will try to get the packaging and current code cleaned up.

@tsalo tsalo linked a pull request Feb 11, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question reports Issues/PRs related to the reports module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants