Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] add maintainers guide #1770

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[DOC] add maintainers guide #1770

wants to merge 8 commits into from

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Apr 11, 2024 •
edited by sappelhoff

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (70d7750) to head (923a1dd).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1770   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files          16       16           
  Lines        1380     1380           
=======================================
  Hits         1215     1215           
  Misses        165      165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christinerogers
Copy link
Contributor

@Remi-Gau @ericearl are there any sanity checks our writer could do here, to get feet wet and hands dirty?

arokem
arokem reviewed Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@arokem arokem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of feedback on this draft at various levels (including in particular points to be cross-referenced elswhere)

Maintainers_Guide.md Outdated Show resolved Hide resolved
Maintainers_Guide.md Outdated Show resolved Hide resolved
Maintainers_Guide.md Outdated Show resolved Hide resolved
Maintainers_Guide.md Outdated Show resolved Hide resolved
Maintainers_Guide.md Outdated Show resolved Hide resolved
Maintainers_Guide.md Show resolved Hide resolved
@Remi-Gau @arokem
Apply suggestions from code review
1859101 
Co-authored-by: Ariel Rokem <arokem@gmail.com>
@Remi-Gau Remi-Gau added exclude-from-changelog This item will not feature in the automatically generated changelog documentation labels Apr 15, 2024
@sappelhoff sappelhoff mentioned this pull request May 31, 2024
Merged
@sappelhoff sappelhoff marked this pull request as ready for review June 2, 2024 10:15
@sappelhoff sappelhoff mentioned this pull request Jun 2, 2024
Open
sappelhoff
sappelhoff approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be +1 on merging this now and then improving it iteratively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arokem arokem arokem left review comments

@sappelhoff sappelhoff sappelhoff approved these changes

@effigies effigies Awaiting requested review from effigies

@christinerogers christinerogers Awaiting requested review from christinerogers

@ericearl ericearl Awaiting requested review from ericearl

@bendhouseart bendhouseart Awaiting requested review from bendhouseart

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move maintainers doc out of spec wiki / google docs and into the website
4 participants
@Remi-Gau @christinerogers @arokem @sappelhoff