Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPM fmap in derivatives are intended for data in the raw dataset #312

Open
Remi-Gau opened this issue Apr 19, 2022 · 2 comments · May be fixed by #339
Open

MPM fmap in derivatives are intended for data in the raw dataset #312

Remi-Gau opened this issue Apr 19, 2022 · 2 comments · May be fixed by #339

Comments

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Apr 19, 2022 •
edited

Detected on a routine check of the datasets with derivatives with bids-matlab.

I may have missed that in the qMRI spec but I am not sure that IntendedFor can cross dataset boundaries.

See here where a fmap in deritvatives is intended for some data in raw:

bids-examples/qmri_mpm/derivatives/hmri/sub-01/fmap/sub-01_acq-MTw_RB1map.json

Line 2 in df982af

"IntendedFor": [

@Remi-Gau
Copy link
Contributor Author

See also: bids-standard/bids-specification#814

@sappelhoff
Copy link
Member

I think with BIDS-URIs this is possible, so the dataset(s) in question should be updated to make use of BIDS-URIs, WDYT?

@Remi-Gau Remi-Gau linked a pull request Oct 29, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] use bids uri for qmri derivatives Remi-Gau/bids-examples
2 participants
@Remi-Gau @sappelhoff