-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model's --write duplicates array properties that have summary and array key-value types added #1505
Model's --write duplicates array properties that have summary and array key-value types added #1505
Comments
Can you add a (failing) test? Or even provide a fix? |
duplication of properties that have generic types specified and descriptions;
duplication of properties that have generic types specified and descriptions;
@mfn This turns out to be a problem with the Created a PR to showcase this bug here and one in that dependency lib to fix this issue, but can't hope that'll be a priority for maintainers. Do you know any other way to fix this locally for the time being? |
Sorry, no. |
duplication of properties that have generic types specified and descriptions;
Versions:
Description:
After specifying the key and value type for an Eloquent Model's array
@property
and adding a comment after that - it duplicates the property.Steps To Reproduce:
address_values
property that is json typed in DB);php artisan ide-helper:models App\\Models\\Client --write
;@property array|null $address_values
;@property array<string, string>|null $address_values some description
;php artisan ide-helper:models App\\Models\\Client --write
;$address_values
property.It works as expected for these variants:
@property array|null $address_values some description
-- no array key-value types;@property array<string, string>|null $address_values
-- no description / summary / text after the property name.Expected behavior is to be able to add both array's key-value types and description (I write some examples there).
The text was updated successfully, but these errors were encountered: