Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "minimal test" option for binding generation #4556

Open
jmayclin opened this issue May 15, 2024 · 0 comments
Open

add "minimal test" option for binding generation #4556

jmayclin opened this issue May 15, 2024 · 0 comments

Comments

@jmayclin
Copy link
Contributor

jmayclin commented May 15, 2024

Problem:

The default developer experience for running the bindings generation script is failure. #4527 added a FIPs feature flag, so cargo test --all-features now requires a go dependency, and fails if it isn't installed. Most people don't have a go dependency installed, so most developers will see the ./generate.sh script fail.

Solution:

It is useful to be able to run some tests when doing local development for the generate script. We should add a --minimal-tests option or something similar to provide a rough sanity check that bindings were generated correctly.

Requirements

The default script run should either

  1. be successful (don't make --all-features the default) or
  2. have a very explicit error message "it seems like you don't have go installed, so you should run this script with --minimal-tests instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants