Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interoperability test for latest oqs-provider #4553

Open
goatgoose opened this issue May 14, 2024 · 1 comment
Open

Add interoperability test for latest oqs-provider #4553

goatgoose opened this issue May 14, 2024 · 1 comment

Comments

@goatgoose
Copy link
Contributor

Problem:

#4544 resolved an issue where the oqs-provider client sent a list of signature schemes that exceeded the s2n-tls maximum, causing the connection to fail. This issue could have been caught in a simple handshake test between s2n-tls and oqs-provider.

The test_pq_handshake integration test contains a test for oqs-provider:

def test_oqs_openssl_to_s2nd_pq_handshake(managed_process, protocol, cipher, kem_group):

However, the oqs-provider version is fixed and outdated, so this issue wasn't caught.

Solution:

Update the oqs-provider version in the test_pq_handshake test, or otherwise add a more recent oqs-provider interoperability test to the CI, to ensure that s2n-tls and oqs-provider can continue to interoperate.

@dougch
Copy link
Contributor

dougch commented Jun 10, 2024

Do we still need oqs ? The liboqs README says: WE DO NOT CURRENTLY RECOMMEND RELYING ON THIS LIBRARY IN A PRODUCTION ENVIRONMENT OR TO PROTECT ANY SENSITIVE DATA. This library is meant to help with research and prototyping. Aren't we getting real world coverage with aws-lc ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants