Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin dependencies after bumping MSRV beyond 1.72 #4518

Open
goatgoose opened this issue Apr 24, 2024 · 1 comment
Open

Unpin dependencies after bumping MSRV beyond 1.72 #4518

goatgoose opened this issue Apr 24, 2024 · 1 comment
Labels
MSRV

Comments

@goatgoose
Copy link
Contributor

Problem:

The zeroize dependency of aws-lc-rs -> s2n-tls-sys has updated their MSRV to 1.72 in v1.8.0. This breaks our build, since our MSRV is < 1.72. The zeroize dependency will be pinned to work around this MSRV increase.

Solution:

zeroize should be unpinned after our MSRV is increased to 1.72.
@goatgoose goatgoose mentioned this issue Apr 24, 2024
Merged
@goatgoose goatgoose changed the title Unpin zeroize after updating s2n-tls-sys MSRV Unpin dependencies after bumping MSRV beyond 1.72 May 2, 2024
@goatgoose goatgoose added the MSRV label May 2, 2024
@dougch
Copy link
Contributor

dougch commented Jun 10, 2024

also #4395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MSRV
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goatgoose @dougch