Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exporting a Sprite Sheet with Group name has different functionality between CLI and Scripting (fix #4456) #4475

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix exporting a Sprite Sheet with Group name has different functionality between CLI and Scripting (fix #4456) #4475

wants to merge 2 commits into from

Conversation

Gasparoken
Copy link
Member

fix #4456

@Gasparoken
Fix exporting a Sprite Sheet with Group name has different functional…
f30c63a 
…ity between CLI and Scripting (fix aseprite#4456)

Before this fix, the lua command:
app.command.ExportSpriteSheet
could not process a layer within a group when the layer name
was expressed using the layer hierarchy path, for example:
layer = "Group1/Layer1"
@Gasparoken
Add test to check that the app.command.ExportSpriteSheet command
a32faa1 
accepts layer name which is expressed by its path in the
layer hierarchy.
For example:
layer = "Group1/Layer1"
@Gasparoken Gasparoken requested a review from dacap as a code owner May 17, 2024 16:17
@aseprite-bot
Copy link
Collaborator

clang-tidy review says "All clean, LGTM! 👍"

@dacap dacap assigned dacap and unassigned martincapello May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincapello martincapello Awaiting requested review from martincapello

@dacap dacap Awaiting requested review from dacap dacap is a code owner

Assignees

@dacap dacap

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Gasparoken @aseprite-bot @dacap @martincapello