Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgrpc package should use interceptors in favor of stats handlers #18258

Open
34fathombelow opened this issue May 16, 2024 · 2 comments · May be fixed by #18366
Open

otelgrpc package should use interceptors in favor of stats handlers #18258

34fathombelow opened this issue May 16, 2024 · 2 comments · May be fixed by #18366
Labels
enhancement New feature or request type:tech-debt Enhancement invisible for the end user

Comments

@34fathombelow
Copy link
Member

Summary

Otelgrpc dependency (go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc) >= v0.46.0 has deprecated the use of StreamServerInterceptor, UnaryServerInterceptor, and StreamClientInterceptor. Migrating to stats handlers should be performed in a future release of Argo CD to guarantee backwards compatability.

@34fathombelow 34fathombelow added enhancement New feature or request type:tech-debt Enhancement invisible for the end user labels May 16, 2024
@Jack-R-lantern
Copy link
Contributor

@34fathombelow

I'm a new contributor.
If this is not too difficult, could you assign it to me?

@blakepettersson
Copy link
Member

@Jack-R-lantern feel free to take this task - this has been worked on in #17790, but is currently failing the E2E tests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request type:tech-debt Enhancement invisible for the end user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants