Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-5773][VL] Update aws-sdk-cpp version to 1.11.285 (from 1.11.169) #5774

Merged
merged 2 commits into from
May 21, 2024
Merged

[GLUTEN-5773][VL] Update aws-sdk-cpp version to 1.11.285 (from 1.11.169) #5774

merged 2 commits into from
May 21, 2024

Conversation

yma11
Copy link
Contributor

@yma11 yma11 commented May 16, 2024

What changes were proposed in this pull request?

update aws-sdk-cpp to version 1.11.285

(Fixes: #5773)

How was this patch tested?

N/A

@github-actions GitHub Actions
Copy link

#5773

@yma11
Copy link
Contributor Author

yma11 commented May 16, 2024

@PHILO-HE please help take a review. Thanks.

@FelixYBW
Copy link
Contributor

So we only updated the the aws-sdk-cpp in vcpkg.

@PHILO-HE Is there any risk if we only update individual components in vcpkg but not vcpkg itself in long term?

@PHILO-HE PHILO-HE changed the title [GLUTEN-5773] update aws-sdk-cpp to version 1.11.285 [GLUTEN-5773] Update aws-sdk-cpp to version 1.11.285 (from 1.11.169) May 17, 2024
@PHILO-HE PHILO-HE changed the title [GLUTEN-5773] Update aws-sdk-cpp to version 1.11.285 (from 1.11.169) [GLUTEN-5773] Update aws-sdk-cpp version to1.11.285 (from 1.11.169) May 17, 2024
@PHILO-HE PHILO-HE changed the title [GLUTEN-5773] Update aws-sdk-cpp version to1.11.285 (from 1.11.169) [GLUTEN-5773] Update aws-sdk-cpp version to 1.11.285 (from 1.11.169) May 17, 2024
@PHILO-HE
Copy link
Contributor

So we only updated the the aws-sdk-cpp in vcpkg.

@PHILO-HE Is there any risk if we only update individual components in vcpkg but not vcpkg itself in long term?

@FelixYBW, I think there is no risk. The only inconvenience is, we have to copy the ports files for some lib from vcpkg and maintain them in Gluten. I can take a try to upgrade vcpkg.

@PHILO-HE
Copy link
Contributor

@yma11, I note this lib is upgraded to 1.11.321 in upstream velox. Do we need to align with it in Gluten?
facebookincubator/velox#9756

PHILO-HE
PHILO-HE previously approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yma11
Copy link
Contributor Author

yma11 commented May 17, 2024

Looks good!

Thanks but wait for a while. May need some extra change. Thanks.

@yma11 yma11 force-pushed the sdk branch 2 times, most recently from 1e69e37 to 4bfb5c8 Compare May 17, 2024 08:40
@yma11 yma11 force-pushed the sdk branch 3 times, most recently from fd654ea to 757f29c Compare May 18, 2024 12:39
@zhztheplayer zhztheplayer merged commit ce92b80 into apache:main May 21, 2024
42 checks passed
@zhztheplayer zhztheplayer changed the title [GLUTEN-5773] Update aws-sdk-cpp version to 1.11.285 (from 1.11.169) [GLUTEN-5773][VL] Update aws-sdk-cpp version to 1.11.285 (from 1.11.169) May 21, 2024
@yma11 yma11 deleted the sdk branch May 31, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhztheplayer zhztheplayer zhztheplayer approved these changes

@PHILO-HE PHILO-HE PHILO-HE left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VL] update aws-sdk-cpp to version 1.11.285
4 participants
@yma11 @FelixYBW @PHILO-HE @zhztheplayer