Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.10 support for the controller #83221

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented May 9, 2024

SUMMARY

Fixes #83094

ISSUE TYPE
  • Feature Pull Request

@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. has_issue labels May 9, 2024
@@ -32,27 +32,8 @@ def import_module(name): # type: ignore[misc]
__import__(name)
return sys.modules[name]

try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Python module needs to support target Python versions, not just controller Python versions. So the Python 2.7 support can be dropped, but not Python 3.8.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a related note, there is more Python 2.7 code that can be removed, such as the use of ansible.module_utils.six.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ansible.module_utils.six is used in quite a few collections all over the place.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not removing that feature -- we're just discontinuing use of it in core where it's no longer needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's totally sensible :) Thanks for clarifying!

@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label May 9, 2024
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label May 10, 2024
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label May 10, 2024
@mattclay
Copy link
Member

This PR is blocked on completion of #83093

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label May 14, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 21, 2024
@mattclay
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattclay
Copy link
Member

I've restarted the tests now that the AZP container has been updated to include Python 3.11.

Before this PR is merged we should check on the status of the updates to the other projects using AZP: ansible-collections/news-for-maintainers#71

Any projects testing against devel will start failing once this is merged, if they haven't updated to the new container.

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 10, 2024
@ansibot
Copy link
Contributor

ansibot commented Jun 10, 2024

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/sanity/ignore.txt:174:1: ansible-test: Ignoring 'ansible-deprecated-version-comment' on 'lib/ansible/galaxy/collection/__init__.py' is unnecessary

click here for bot help

# Remove this once py3.11 is our controller minimum
# Workaround for https://bugs.python.org/issue47231
# See _extract_tar_dir
collection_tar._ansible_normalized_cache = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unit tests that still refer to this and will need to be updated.

@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci_verified Changes made in this PR are causing tests to fail. feature This issue/PR relates to a feature request. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.10 on the controller
5 participants