Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-infra): prevent doc-icons from being translated #2056

Closed
wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label May 11, 2024
@josephperrott
Copy link
Member

This PR was merged into the repository by commit cefae44.

@mattyonder
Copy link

I believe I must have made a mistake in my communication, I apologize for that, but this translation error is not only on the angular.dev home screen, from what I explored here, it is on all pages of the site I believe.

@JeanMeche
Copy link
Member Author

Yes, this will fix the issue on every page once angular/angular#55781 is merged.

@JeanMeche JeanMeche deleted the docs/translate branch May 13, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error after translate angular.dev for portuguese.
3 participants