Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing local data - World Locations #6276

Open
chris-gds opened this issue Sep 10, 2021 · 2 comments
Open

Missing local data - World Locations #6276

chris-gds opened this issue Sep 10, 2021 · 2 comments

Comments

@chris-gds
Copy link
Contributor

chris-gds commented Sep 10, 2021 •
edited

What

Inaccurate or missing data on local - revealed working on this PR

  • announcements
  • latest
  • images

How to replicate:

Live / Integration > Local

gov.uk/world/france/news

Screenshot 2021-09-10 at 13 01 27

Screenshot 2021-09-10 at 13 01 17

Screenshot 2021-09-10 at 13 01 05
@chris-gds chris-gds changed the title Missing Local data Missing Local data -world locations Sep 10, 2021
@chris-gds chris-gds changed the title Missing Local data -world locations Missing Local data - world locations Sep 10, 2021
@chris-gds chris-gds changed the title Missing Local data - world locations Missing local data - World Locations Sep 10, 2021
@owenatgov
Copy link
Contributor

Why did this stop the PR from getting merged in when I initially approved it over a month ago?

@chris-gds
Copy link
Contributor Author

chris-gds commented Oct 2, 2021 •
edited

Mainly as this page wasn't able to be updated in insolation / reflective of the ways tickets were split up. There were multiple files with /app/views/shared that required updating across many pages and templates in parallel.

Rather than implement an isolated fix to get merged, felt it made more sense to wait for the other updates and merge together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@owenatgov @chris-gds