Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Psych::BadAlias: Unknown alias: nested_attachment_field_names #3684

Open
andrewgarner opened this issue Jan 16, 2018 · 0 comments
Open

Investigate Psych::BadAlias: Unknown alias: nested_attachment_field_names #3684

andrewgarner opened this issue Jan 16, 2018 · 0 comments

Comments

@andrewgarner
Copy link
Contributor

test/unit/text_direction_test.rb contains a YAML.load invocation, it would be preferable to replace this with YAML.safe_load however doing so produces the following test failure:

TextDirectionTest#test_explicitly_sets_text_direction_for_en.yml:¬
Psych::BadAlias: Unknown alias: nested_attachment_field_names¬

The en.yml file contains the folowing line which appears to be invalid YAML:

nested_attachment_field_names: &nested_attachment_field_names
andrewgarner added a commit that referenced this issue Jan 16, 2018
@andrewgarner
Fix Security/YAMLLoad offenses
c05ba7a 
The cop is disabled for the `TextDirectionTest` because

Replacing `YAML.load` with `YAML.safe_load` produces the following
test failure:

```
TextDirectionTest#test_explicitly_sets_text_direction_for_en.yml:
Psych::BadAlias: Unknown alias: nested_attachment_field_names
```

The en.yml file contains the folowing line which appears to be invalid YAML:

```
nested_attachment_field_names: &nested_attachment_field_names
```

See #3684
@andrewgarner andrewgarner mentioned this issue Jan 16, 2018
Merged
andrewgarner added a commit that referenced this issue Jan 16, 2018
@andrewgarner
Fix Security/YAMLLoad offences
fb2e14f 
The cop is disabled for the `TextDirectionTest` because

Replacing `YAML.load` with `YAML.safe_load` produces the following
test failure:

```
TextDirectionTest#test_explicitly_sets_text_direction_for_en.yml:
Psych::BadAlias: Unknown alias: nested_attachment_field_names
```

The en.yml file contains the folowing line which appears to be invalid YAML:

```
nested_attachment_field_names: &nested_attachment_field_names
```

See #3684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewgarner