Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand documentation of fieldset to discuss when to add role="group" #3794

Open
edwardhorsford opened this issue May 14, 2024 · 0 comments
Open
Labels
awaiting triage Needs triaging by team documentation User requests new documentation or improvements to existing documentation

Comments

@edwardhorsford
Copy link
Contributor

The date component has role="group" on its fieldset. The fieldset component example doesn't.

Via @36degrees, this is what the code has to say:

We override the fieldset's role to 'group' because otherwise JAWS does not
announce the description for a fieldset comprised of text inputs, but
adding the role to the fieldset always makes the output overly verbose for
radio buttons or checkboxes.

If this is still true, then it would be good to add something to the fieldset example discussing it. It may not be relevant to radios and checkboxes, but I suspect most usages of the fieldset component itself are likely for other elements.

Suggestion

@edwardhorsford edwardhorsford added awaiting triage Needs triaging by team documentation User requests new documentation or improvements to existing documentation labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage Needs triaging by team documentation User requests new documentation or improvements to existing documentation
Projects
None yet
Development

No branches or pull requests

1 participant