Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to CE3/FS2 3 #898

Open
keynmol opened this issue Dec 2, 2021 · 0 comments
Open

Upgrade to CE3/FS2 3 #898

keynmol opened this issue Dec 2, 2021 · 0 comments

Comments

@keynmol
Copy link

keynmol commented Dec 2, 2021

I was quite surprised to find out that Almond uses fs2 :) https://github.com/almond-sh/almond/blob/master/modules/shared/interpreter/src/main/scala/almond/interpreter/input/InputHandler.scala

Makes sense, when I think about it.

Would it be possible to either

  1. Upgrade to 3.x lineage of FS2
  2. Remove fs2 as a dependency

I only spotted it because I wrap almond in a project that uses CE, and that blocks the upgrade to CE3.

Will happily PR an upgrade to FS2 3.x as long as there's agreement, less certain about what removing fs2 would involve.

WDYT @alexarchambault ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant