Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Membership class should not need to care about 'set mode' #80

Open
ots22 opened this issue Dec 22, 2022 · 0 comments
Open

Membership class should not need to care about 'set mode' #80

ots22 opened this issue Dec 22, 2022 · 0 comments

Comments

@ots22
Copy link
Member

ots22 commented Dec 22, 2022

At the moment this is only used in matching_intersections, and the results can be expressed in an alternative way that is the same whichever mode is used.

The mode is also used by the various plotting classes and currently this is taken from a Membership object. Since this is then basically only used as a flag to configure the plots, it would be better obtained from elsewhere, or passed directly to the plotting classes. A PlotSession has a member '_set_mode' which could be used for this purpose.

@ots22 ots22 added this to To do in Project planning Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant