Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #58

Open
2 of 6 tasks
ots22 opened this issue Nov 15, 2021 · 8 comments
Open
2 of 6 tasks

Add documentation #58

ots22 opened this issue Nov 15, 2021 · 8 comments
Labels
documentation Improvements or additions to documentation

Comments

@ots22
Copy link
Member

ots22 commented Nov 15, 2021

  • Docstrings for modules, classes and major functions
  • Sphinx doc description: include set visualisation in the description (in addition to missingness)
  • Landing page: general description of the package and show a basic example
  • Overview: complete this page (or remove)
  • Link to the tutorial (or: include notebooks in sphinx pages?)
  • Add instructions to README for building the docs
@ots22 ots22 created this issue from a note in Project planning (To do) Nov 15, 2021
@pwochner pwochner moved this from To do to In progress in Project planning Nov 18, 2021
@layik
Copy link
Collaborator

layik commented Jan 24, 2023

#95
Can I just check if we meant to use pydata_sphinx_theme (in conf.py) rather than sphinx-rtd-theme and also whether the latter is the "readthedocs" theme? Thanks.

@layik layik added the documentation Improvements or additions to documentation label Jan 24, 2023
@layik
Copy link
Collaborator

layik commented Jan 24, 2023

the latter is the "readthedocs" theme? Thanks.

Yep just tried it. Can I change the entry to sphinx_rtd_theme please? As it looks much better.

@ots22
Copy link
Member Author

ots22 commented Jan 24, 2023

The pydata theme was a deliberate choice, partly to make it consistent with other python data science tooling (numpy, pandas etc all use it).

Personally I prefer this theme though! Is there anything we could adjust to make it look nicer in your view?

@ots22
Copy link
Member Author

ots22 commented Jan 24, 2023

I ticked the docstrings box, since I think we're pretty much done with these now - can open new issues with anything we want to tweak.

@layik
Copy link
Collaborator

layik commented Jan 24, 2023

The pydata theme was a deliberate choice, partly to make it consistent with other python data science tooling (numpy, pandas etc all use it).

Great. Glad it's a deliberate choice.

Personally I prefer this theme though! Is there anything we could adjust to make it look nicer in your view?

Nothing specific, I am possibly too used to rtd.

@layik
Copy link
Collaborator

layik commented Jan 28, 2023

Related #109

layik added a commit that referenced this issue Feb 2, 2023
@layik layik mentioned this issue Feb 2, 2023
3 tasks
layik added a commit that referenced this issue Feb 8, 2023
Attempt at addressing #58 checkbox 2 and/or 3
@layik
Copy link
Collaborator

layik commented Feb 26, 2023

Overview page is empty?

https://setvis.readthedocs.io/en/latest/overview.html

@ots22
Copy link
Member Author

ots22 commented Feb 26, 2023

Thanks, added to the list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Project planning
In progress
Development

No branches or pull requests

2 participants