Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Stimulus 2.0 Values API #69

Open
noahfpf opened this issue Feb 2, 2021 · 2 comments
Open

Support Stimulus 2.0 Values API #69

noahfpf opened this issue Feb 2, 2021 · 2 comments

Comments

@noahfpf
Copy link

noahfpf commented Feb 2, 2021

Support for Stimulus 2.0's Values API would be useful, so that flatpickr options could be provided as attributes like data-flatpickr-the-option-value (in addition to deprecated support for data-flatpickr-the-option).

I think that support would be straight-forward and I could likely provide a PR.

(And thanks for providing this helpful and clean library!)

@adrienpoly
Copy link
Owner

yes this is definitely on my roadmap to support the value API. And some overalls clean up of this library, but I was quite busy with Stimulus Use recently.

Also initially I wanted to wait for this PR to be merged as I think it could simplify the implementation. But it is not mandatory to wait for that.

A PR would be very welcome and could be a starting point for a v2.0 of this package.

@noahfpf
Copy link
Author

noahfpf commented Feb 10, 2021

A PR would be very welcome and could be a starting point for a v2.0 of this package.

Do you want it to be backwards compatible with v1.0 this.data support, or to only support the new *-value attribute names? Either seems reasonable, with the latter an option if you're planning on a breaking 2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants