Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle command should work with different versions #19602

Closed
yekalkan opened this issue Apr 22, 2024 · 10 comments · Fixed by #19842
Closed

Bundle command should work with different versions #19602

yekalkan opened this issue Apr 22, 2024 · 10 comments · Fixed by #19842

Comments

@yekalkan
Copy link
Member

We will separate framework and cli versions soon. So, version matching in bundle command will be a problem.

@maliming You can ask me and @enisn for more information.

@enisn
Copy link
Member

enisn commented Apr 22, 2024

Here is the case:

ABP CLI version is 8.1.1 and when you try to run abp bundle for project with ABP version 8.0.2 it fails to load DLLs since because it tries to load all project assemblies into CLI's own process at runtime,

@maliming
Copy link
Member

It works for me.

image

@skoc10 skoc10 modified the milestones: 8.2-preview, 8.2-final Apr 25, 2024
@maliming maliming modified the milestones: 8.2-preview, 8.3-preview May 13, 2024
@enisn
Copy link
Member

enisn commented May 13, 2024

This is a wider problem, maybe we can install local tool in the directory with the same version with project instead using global in project folders

@maliming
Copy link
Member

it fails to load DLLs

How can I reproduce this?

@enisn
Copy link
Member

enisn commented May 13, 2024

It works now with 8.3/8.2 CLI on 8.0 projects. But When you try to bundle project 7.4 or version with breaking-changes it'll fail.

How about placing dotnet-tools.json in projects with the same version of project and execute always same CLI version with project?

image

@enisn
Copy link
Member

enisn commented May 13, 2024

Each project can use their own version CLI different than global cli version

@maliming
Copy link
Member

maliming commented May 13, 2024

Developers should use the same CLI version as the project package version, at least the same NET platform version. (net 7, net 8)


Of course, they can install CLI at the folder level.

https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-tool-install#description

@enisn
Copy link
Member

enisn commented May 14, 2024

Developers should use the same CLI version as the project package version, at least the same NET platform version. (net 7, net 8)

Of course, they can install CLI at the folder level.

https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-tool-install#description

Should we include dotnet-tools.json file in the templates?

@maliming
Copy link
Member

We can output a warning message for the abp bundle command and add a document to explain this.

Include dotnet-tools.json still requires the developer to do extra work, so I think we can tell the developer to install the CLI herself/himself.

@enisn
Copy link
Member

enisn commented May 14, 2024

Yes,dotnet tool restore must be executed manually, so it needs extra work. You're right, we can explain with warning message when version mismatch with project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants