Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAP GUI for HTML: Toolbar on Repository List not working #6567

Open
mbtools opened this issue Oct 24, 2023 · 0 comments
Open

SAP GUI for HTML: Toolbar on Repository List not working #6567

mbtools opened this issue Oct 24, 2023 · 0 comments
Labels
low priority Not that important but keep open user interface How to interact with abapGit

Comments

@mbtools
Copy link
Member

mbtools commented Oct 24, 2023

Trying any toolbar option leads to error Repository not found in database. Key: REPO, #:

image

GUI for Windows:

image

GUI for HTML:

image

Cause:

The toolbar options are rendered as a elements which should work with SAP GUI for HTML. However, appending the selected repository key to the link does not work.

JS:

RepoOverViewHelper.prototype.updateActionLinks = function(selectedRow) {
// now we have a repo selected, determine which action buttons are relevant
var selectedRepoKey = selectedRow.dataset.key;
var selectedRepoIsOffline = selectedRow.dataset.offline === "X";
var actionLinks = document.querySelectorAll("a.action_link");
actionLinks.forEach(function(link) {
// adjust repo key in urls
link.href = link.href.replace(/\?key=(#|\d+)/, "?key=" + selectedRepoKey);
// toggle button visibility
if (link.classList.contains("action_offline_repo")) {
if (selectedRepoIsOffline) {
link.parentElement.classList.add("enabled");
} else {
link.parentElement.classList.remove("enabled");
}
}
else if (link.classList.contains("action_online_repo")) {
if (!selectedRepoIsOffline) {
link.parentElement.classList.add("enabled");
} else {
link.parentElement.classList.remove("enabled");
}
}
else {
// if the action is for both repository types, it will only have the .action_link class
// it still needs to be toggled as we want to hide everything if no repo is selected
link.parentElement.classList.add("enabled");
}
});
};

@mbtools mbtools added bug Something isn't working user interface How to interact with abapGit labels Oct 24, 2023
@larshp larshp assigned mbtools and unassigned mbtools Nov 23, 2023
@mbtools mbtools added low priority Not that important but keep open and removed bug Something isn't working labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Not that important but keep open user interface How to interact with abapGit
Development

No branches or pull requests

1 participant